Closed
Conversation
Only the python3 executable is guaranteed Signed-off-by: RocketDev <ma2014119@outlook.com>
Though setup.py is deprecated, but we'd better fix shebang now... Signed-off-by: RocketDev <ma2014119@outlook.com>
Member
|
Thanks for picking this up @RocketMaDev. This looks good to me, so I'm going to go ahead and merge this into the main branch via 18e4955, but leave this PR open so we can discuss backporting to the release-2.6 branch. I will note that I manually performed the /python/python3/ change in test 63 as it was just merged before this PR. What do you think @drakenclimber, should we backport this for v2.6.z? I'm inclined to backport it. |
Member
|
I was talking with @drakenclimber outside this issue and he agreed we should do the backport, so I've done just that at 6abe14d. Thanks again everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a commit apply fix from #440 since the old fix was not completed and stale. Just
sed -i 's|#!/usr/bin/env python|#!/usr/bin/env python3|' tests/*.pycould fix this problem.Fix #477, close #440.